Remove workaround for http response tracer #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2514 +/- ##
==========================================
- Coverage 10.66% 10.64% -0.02%
==========================================
Files 106 106
Lines 10672 10644 -28
==========================================
- Hits 1138 1133 -5
+ Misses 9384 9360 -24
- Partials 150 151 +1
Continue to review full report at Codecov.
|
nitisht
requested review from
vadmeste,
nitisht and
kannappanr
and removed request for
vadmeste
nitisht
approved these changes
Aug 17, 2018
kannappanr
reviewed
Aug 17, 2018
| return err | ||
| } | ||
| } | ||
| respTrace, err = httputil.DumpResponse(resp, false) |
There was a problem hiding this comment.
Previously we used to return on error here. Why are we not ding that now? If we don't return this code will get executed,
dumpTLSCertificates(resp.TLS)
}
Is that intended?
There was a problem hiding this comment.
it really doesn't matter... we can still print TLS information.
kannappanr
approved these changes
Aug 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.