Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display config in correct format when json flag is used #2544

Merged
merged 1 commit into from
Sep 19, 2018

Conversation

kannappanr
Copy link
Collaborator

Previously config was encoded in Base64 format. Fixed the code to not do that anymore.
Fixes #2530

cmd/admin-config-get.go Outdated Show resolved Hide resolved
cmd/admin-config-get.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #2544 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2544      +/-   ##
=========================================
- Coverage    10.6%   10.6%   -0.01%     
=========================================
  Files         104     104              
  Lines        8326    8327       +1     
=========================================
  Hits          883     883              
- Misses       7292    7293       +1     
  Partials      151     151
Impacted Files Coverage Δ
cmd/admin-config-get.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044a95b...4fe1931. Read the comment docs.

cmd/admin-config-get.go Outdated Show resolved Hide resolved
cmd/admin-config-get.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #2544 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2544      +/-   ##
==========================================
+ Coverage    10.6%   10.63%   +0.02%     
==========================================
  Files         104      106       +2     
  Lines        8326    10704    +2378     
==========================================
+ Hits          883     1138     +255     
- Misses       7292     9416    +2124     
+ Partials      151      150       -1
Impacted Files Coverage Δ
cmd/admin-config-get.go 0% <0%> (ø) ⬆️
cmd/session.go 35.89% <0%> (-6.48%) ⬇️
cmd/humanized-duration.go 59.57% <0%> (-4.53%) ⬇️
cmd/pipechan.go 97.56% <0%> (-2.44%) ⬇️
cmd/utils.go 32.07% <0%> (-1.01%) ⬇️
cmd/pretty-table.go 82.85% <0%> (-0.48%) ⬇️
cmd/mirror-url.go 4.47% <0%> (-0.24%) ⬇️
cmd/find-main.go 0% <0%> (ø) ⬆️
cmd/mb-main.go 0% <0%> (ø) ⬆️
cmd/share-db-v1.go 0% <0%> (ø) ⬆️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044a95b...4fe1931. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #2544 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2544      +/-   ##
==========================================
+ Coverage    10.6%   10.63%   +0.02%     
==========================================
  Files         104      106       +2     
  Lines        8326    10704    +2378     
==========================================
+ Hits          883     1138     +255     
- Misses       7292     9416    +2124     
+ Partials      151      150       -1
Impacted Files Coverage Δ
cmd/admin-config-get.go 0% <0%> (ø) ⬆️
cmd/session.go 35.89% <0%> (-6.48%) ⬇️
cmd/humanized-duration.go 59.57% <0%> (-4.53%) ⬇️
cmd/pipechan.go 97.56% <0%> (-2.44%) ⬇️
cmd/utils.go 32.07% <0%> (-1.01%) ⬇️
cmd/pretty-table.go 82.85% <0%> (-0.48%) ⬇️
cmd/mirror-url.go 4.47% <0%> (-0.24%) ⬇️
cmd/find-main.go 0% <0%> (ø) ⬆️
cmd/mb-main.go 0% <0%> (ø) ⬆️
cmd/share-db-v1.go 0% <0%> (ø) ⬆️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044a95b...4fe1931. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #2544 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2544      +/-   ##
==========================================
+ Coverage    10.6%   10.63%   +0.02%     
==========================================
  Files         104      106       +2     
  Lines        8326    10704    +2378     
==========================================
+ Hits          883     1138     +255     
- Misses       7292     9416    +2124     
+ Partials      151      150       -1
Impacted Files Coverage Δ
cmd/admin-config-get.go 0% <0%> (ø) ⬆️
cmd/session.go 35.89% <0%> (-6.48%) ⬇️
cmd/humanized-duration.go 59.57% <0%> (-4.53%) ⬇️
cmd/pipechan.go 97.56% <0%> (-2.44%) ⬇️
cmd/utils.go 32.07% <0%> (-1.01%) ⬇️
cmd/pretty-table.go 82.85% <0%> (-0.48%) ⬇️
cmd/mirror-url.go 4.47% <0%> (-0.24%) ⬇️
cmd/find-main.go 0% <0%> (ø) ⬆️
cmd/mb-main.go 0% <0%> (ø) ⬆️
cmd/share-db-v1.go 0% <0%> (ø) ⬆️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044a95b...4fe1931. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #2544 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2544      +/-   ##
==========================================
+ Coverage    10.6%   10.63%   +0.02%     
==========================================
  Files         104      106       +2     
  Lines        8326    10704    +2378     
==========================================
+ Hits          883     1138     +255     
- Misses       7292     9416    +2124     
+ Partials      151      150       -1
Impacted Files Coverage Δ
cmd/admin-config-get.go 0% <0%> (ø) ⬆️
cmd/session.go 35.89% <0%> (-6.48%) ⬇️
cmd/humanized-duration.go 59.57% <0%> (-4.53%) ⬇️
cmd/pipechan.go 97.56% <0%> (-2.44%) ⬇️
cmd/utils.go 32.07% <0%> (-1.01%) ⬇️
cmd/pretty-table.go 82.85% <0%> (-0.48%) ⬇️
cmd/mirror-url.go 4.47% <0%> (-0.24%) ⬇️
cmd/find-main.go 0% <0%> (ø) ⬆️
cmd/mb-main.go 0% <0%> (ø) ⬆️
cmd/share-db-v1.go 0% <0%> (ø) ⬆️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044a95b...1bb4f17. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #2544 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2544      +/-   ##
==========================================
+ Coverage    10.6%   10.62%   +0.01%     
==========================================
  Files         104      106       +2     
  Lines        8326    10703    +2377     
==========================================
+ Hits          883     1137     +254     
- Misses       7292     9416    +2124     
+ Partials      151      150       -1
Impacted Files Coverage Δ
cmd/admin-config-get.go 0% <0%> (ø) ⬆️
cmd/session.go 35.89% <0%> (-6.48%) ⬇️
cmd/pipechan.go 95.12% <0%> (-4.88%) ⬇️
cmd/humanized-duration.go 59.57% <0%> (-4.53%) ⬇️
cmd/utils.go 32.07% <0%> (-1.01%) ⬇️
cmd/pretty-table.go 82.85% <0%> (-0.48%) ⬇️
cmd/mirror-url.go 4.47% <0%> (-0.24%) ⬇️
cmd/find-main.go 0% <0%> (ø) ⬆️
cmd/mb-main.go 0% <0%> (ø) ⬆️
cmd/share-db-v1.go 0% <0%> (ø) ⬆️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044a95b...1bb4f17. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #2544 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2544      +/-   ##
==========================================
+ Coverage    10.6%   10.62%   +0.01%     
==========================================
  Files         104      106       +2     
  Lines        8326    10703    +2377     
==========================================
+ Hits          883     1137     +254     
- Misses       7292     9416    +2124     
+ Partials      151      150       -1
Impacted Files Coverage Δ
cmd/admin-config-get.go 0% <0%> (ø) ⬆️
cmd/session.go 35.89% <0%> (-6.48%) ⬇️
cmd/pipechan.go 95.12% <0%> (-4.88%) ⬇️
cmd/humanized-duration.go 59.57% <0%> (-4.53%) ⬇️
cmd/utils.go 32.07% <0%> (-1.01%) ⬇️
cmd/pretty-table.go 82.85% <0%> (-0.48%) ⬇️
cmd/mirror-url.go 4.47% <0%> (-0.24%) ⬇️
cmd/find-main.go 0% <0%> (ø) ⬆️
cmd/mb-main.go 0% <0%> (ø) ⬆️
cmd/share-db-v1.go 0% <0%> (ø) ⬆️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044a95b...1bb4f17. Read the comment docs.

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit c9f3369 into minio:master Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants