Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --api to the configure host part #2555

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Conversation

martbhell
Copy link
Contributor

No description provided.

@nitisht
Copy link
Contributor

nitisht commented Sep 26, 2018

@martbhell can you please explain why is this needed?

@martbhell
Copy link
Contributor Author

martbhell commented Sep 26, 2018

Hello @nitisht for our ceph RGW S3 endpoint it doesn't work without --api:

$ ./mc config host add pouta https://object.pouta.csc.fi:443 myaccesskey mysecretkey S3v2
mc:  Unable to initialize new config from the provided credentials. The access key ID you provided does not exist in our records.
$ ./mc config host add pouta https://object.pouta.csc.fi:443 myaccesskey mysecretkey --api S3v2
Added `pouta` successfully.

Is it enough to explain in here or would you like it in the commit too?

@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #2555 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2555      +/-   ##
=========================================
- Coverage   10.62%   10.6%   -0.02%     
=========================================
  Files         106     106              
  Lines       10723   10723              
=========================================
- Hits         1139    1137       -2     
- Misses       9434    9436       +2     
  Partials      150     150
Impacted Files Coverage Δ
cmd/pipechan.go 95.12% <0%> (-4.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f7e65...1d7789a. Read the comment docs.

@nitisht nitisht requested review from nitisht and vadmeste September 26, 2018 12:38
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit a215fbb into minio:master Sep 26, 2018
Praveenrajmani pushed a commit to Praveenrajmani/mc that referenced this pull request Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants