Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse alias set via env variable while parsing encryption key #2581

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

kannappanr
Copy link
Collaborator

Check MC_HOSTS_ env variable also while looking for the alias to set encryption key
Fixes #2580

@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #2581 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2581      +/-   ##
=========================================
+ Coverage   10.08%   10.1%   +0.01%     
=========================================
  Files         121     121              
  Lines       11241   11247       +6     
=========================================
+ Hits         1134    1136       +2     
- Misses       9957    9961       +4     
  Partials      150     150
Impacted Files Coverage Δ
cmd/config.go 22.52% <0%> (-0.77%) ⬇️
cmd/pipechan.go 100% <0%> (+4.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab117c...b3dad31. Read the comment docs.

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Check MC_HOSTS_ env variable also while looking for the alias to set encryption key
Fixes minio#2580
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 73a61b4 into minio:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants