Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idp ldap accesskey #4686

Merged
merged 18 commits into from
Oct 26, 2023
Merged

Add idp ldap accesskey #4686

merged 18 commits into from
Oct 26, 2023

Conversation

taran-p
Copy link
Contributor

@taran-p taran-p commented Sep 19, 2023

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Add functions to mc for LDAP access keys, new versions of some functionality provided by mc admin user svcacct.

mc idp ldap accesskey list lists all temporary and permanent access keys for admin users, or only a users own accesskeys for users without permission to view other's access keys.
mc idp ldap accesskey delete deletes an access key assuming appropriate permissions
mc idp ldap accesskey info provides more detailed information about a given access key.

Also add .vscode/ folder to gitignore

Motivation and Context

How to test this PR?

Run a minio server that uses LDAP and check functionality of commands

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@taran-p taran-p changed the title Idp ldap accesskey Add idp ldap accesskey Sep 26, 2023
@taran-p taran-p marked this pull request as ready for review October 4, 2023 04:13
@taran-p taran-p requested a review from donatello October 5, 2023 00:37
@taran-p taran-p marked this pull request as draft October 5, 2023 05:15
@taran-p taran-p marked this pull request as ready for review October 6, 2023 21:33
@harshavardhana
Copy link
Member

PTAL @donatello

@donatello
Copy link
Member

PTAL @donatello

We're discussing this offline, will update here when it's ready.

@harshavardhana
Copy link
Member

PTAL @donatello

@donatello donatello merged commit c1f61a1 into minio:master Oct 26, 2023
5 checks passed
@taran-p taran-p deleted the idp-ldap-accesskey branch October 26, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants