Add --bucket-bandwidth flag to mc admin replicate update
#4687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poornas
force-pushed
the
site-bw-config
branch
from
9a36d3e to
18181ca
Compare
harshavardhana
approved these changes
Sep 28, 2023
shtripat
reviewed
Sep 28, 2023
There was a problem hiding this comment.
I have a site replication set across two local MinIO instances as below
./mc admin replicate info m1
SiteReplication enabled for:
Deployment ID | Site Name | Endpoint | Sync | Bandwidth
| | | | Per Bucket
d4a37885-92bf-490f-8b13-8758b14b4252 | m1 | http://localhost:9000 | | N/A
1c8d3dee-4dde-4b0a-91c4-a8a0ba5397e4 | m2 | http://localhost:9010 | | N/A
But below two commands display the help only
./mc admin replicate update --deployment-id d4a37885-92bf-490f-8b13-8758b14b4252 --endpoint http://localhost:9010./mc admin replicate update --deployment-id d4a37885-92bf-490f-8b13-8758b14b4252 --endpoint http://localhost:9010 --bucket-bandwidth 2000
Anything wrong here?
| }, | ||
| cli.StringFlag{ | ||
| Name: "bucket-bandwidth", | ||
| Usage: "Set default bandwidth limit for bucket in bits per second (K,B,G,T for metric and Ki,Bi,Gi,Ti for IEC units)", |
There was a problem hiding this comment.
Please add help entries for these flags like bucket-bandwidth, mode, sync etc
harshavardhana
approved these changes
Sep 28, 2023
|
PTAL at the conflicts @poornas |
to allow default bucket bandwidth to be set in site replication
poornas
force-pushed
the
site-bw-config
branch
from
d86fd2a to
bef1ffc
Compare
harshavardhana
approved these changes
Oct 11, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to allow default bucket bandwidth to be set in site replication
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Motivation and Context
How to test this PR?
with minio PR
Types of changes
Checklist:
commit-idorPR #here)