Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broaden reach of --no-color flag #4697

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

taran-p
Copy link
Contributor

@taran-p taran-p commented Sep 26, 2023

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Allow --no-color flag to affect commands that use lipgloss for formatting

Motivation and Context

Fixes #4696

How to test this PR?

use --no-color on any command that uses lipgloss, like mc admin policy entities or mc idp ldap info

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana harshavardhana merged commit 618512c into minio:master Sep 26, 2023
5 checks passed
@taran-p taran-p deleted the fix-color branch October 9, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--no-color flag does not respect commands that use lipgloss for string formatting
2 participants