Add ART and ATP to 'support top api' command #4699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
The "mc support top api" command already displays the RX, TX, CALLS, and ERRORS.
This commit adds the average request time (ART) and the average throughput (ATP) to the output.
Average Request Time (ART) = Total Duration / Calls
Average Throughput (ATP) = (RX+TX) / Total Duration
Motivation and Context
There already was a TODO comment about ART in the code.
With ATP and ARP added to the output the user can get a quick impression on the current "performance" of his API calls.
How to test this PR?
Execute
mc support top api TARGET
and watch the output.Types of changes
Checklist:
commit-id
orPR #
here)