Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ART and ATP to 'support top api' command #4699

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

aweisser
Copy link
Contributor

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

The "mc support top api" command already displays the RX, TX, CALLS, and ERRORS.
This commit adds the average request time (ART) and the average throughput (ATP) to the output.

Average Request Time (ART) = Total Duration / Calls
Average Throughput (ATP) = (RX+TX) / Total Duration

grafik

Motivation and Context

There already was a TODO comment about ART in the code.
With ATP and ARP added to the output the user can get a quick impression on the current "performance" of his API calls.

How to test this PR?

Execute mc support top api TARGET and watch the output.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Average Request Time (ART) = Total Duration / Calls
Average Throughput (ATP) = (RX+TX) / Total Duration
@harshavardhana harshavardhana merged commit c3c899c into minio:master Sep 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants