-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ldap accesskey create
, update accesskey list
with new endpoint
#4760
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me (pending testing) - is there anything left to be done? if not please mark it as ready for review.
Everything is ready, but it's dependent on the serverside PR that is still being worked on. I can mark it as ready if it makes sense to |
78848f1
to
466a51d
Compare
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Not ready for review
Accompanying minio/minio#18402
Adds
mc idp ldap accesskey create
, which creates an LDAP access key with desired settings, and can take both short LDAP username or full DN as an input user, or none to create one for the authenticated user.Adds
mc idp ldap accesskey create --login
for use in an interactive terminal, which allows a user to input their LDAP username and password and returns a corresponding access key with desired settings.Changes
mc idp ldap accesskey list
so it uses new API endpoint, which verifies the user is in LDAP and can take both short username and full DN. Also changes--temp-only
to--sts-only
and--permanent-only
to--svcacct-only
to avoid confusion.Motivation and Context
How to test this PR?
Types of changes
Checklist:
commit-id
orPR #
here)