Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #4518 MC SQL to correctly parse ndjson files with extension .ndjson #4809

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Dec 29, 2023

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

fix #4518

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@jiuker
Copy link
Contributor Author

jiuker commented Jan 2, 2024

@klauspost cc

@jiuker jiuker requested review from shtripat and zveinn January 3, 2024 06:45
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified.
If loaded the object with --attr="content-type=application/json" the output works fine for mc sql --recursive --query="select * from s3object" myminio/test-bucket --json-input type=lines

@harshavardhana harshavardhana merged commit 0ffee47 into minio:master Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MC SQL to correctly parse ndjson files with extension .ndjson
3 participants