Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to update tier credentials for Azure service principal ac… #4975

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

marktheunissen
Copy link
Contributor

@marktheunissen marktheunissen commented Jul 3, 2024

…counts

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Add the ability to edit (update) the creds of an Azure tier using mc ilm tier update ALIAS MYTIER --az-sp-client-id ...
with the 3 az-sp credentials

Motivation and Context

Part of the tiering functionality.

How to test this PR?

❯ ./mc ilm tier update ALIAS MYTIER --az-sp-client-id UUID --az-sp-tenant-id UUID --az-sp-client-secret SECRET

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@harshavardhana harshavardhana merged commit 26680ab into minio:master Jul 3, 2024
6 checks passed
@marktheunissen marktheunissen deleted the spazureedit branch July 3, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants