Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heal: Adapt the status based on a new Finished flag #5017

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

vadmeste
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

In a new MinIO version, Healing can be set to false while HealInfo is not nil.
This indicates that the drive was healed and the healing is finished. This commit
adapts the code with the new concept. This will not break with older MinIO
versions since those versions will already remove .healing.bin, in that case
Healing will be false, HealInfo will be nil.

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can expand it later.

@harshavardhana
Copy link
Member

update go.mod @vadmeste also fix the title.

@vadmeste vadmeste force-pushed the avoid-healing-bin-removal branch from a81c242 to 02309f2 Compare August 19, 2024 10:56
@vadmeste vadmeste changed the title [go.mod fix required] heal: Adapt the status based on a new Finished flag heal: Adapt the status based on a new Finished flag Aug 19, 2024
@vadmeste
Copy link
Member Author

@harshavardhana PTAL

go.mod Outdated Show resolved Hide resolved
In a new MinIO version, Healing can be set to false while HealInfo is
not nil. This indicates that the drive was healed and the healing is
finished. This commit adapts the code with the new concept. This will
not break with older MinIO versions since those versions will already
remove .healing.bin, in that case Healing will be false, HealInfo will
be nil.
@vadmeste vadmeste force-pushed the avoid-healing-bin-removal branch from 02309f2 to 3591a90 Compare August 21, 2024 11:27
@harshavardhana harshavardhana merged commit aca5c18 into minio:master Aug 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants