Add commands for managing Bucket CORS #5019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marktheunissen
force-pushed
the
bucketcors-commands
branch
2 times, most recently
from
df83db8 to
1fae1d1
Compare
8 tasks
marktheunissen
requested review from
harshavardhana and
zveinn
and removed request for
harshavardhana
marktheunissen
force-pushed
the
bucketcors-commands
branch
from
1fae1d1 to
fb27613
Compare
zveinn
reviewed
Aug 13, 2024
| } | ||
|
|
||
| // corsMessage container for output message. | ||
| type corsMessage struct { |
There was a problem hiding this comment.
Since this msg is used by all commands.. maybe it and it's methods should live in the cord-main.go file.
There was a problem hiding this comment.
@zveinn Good point, and I agree, but I put corsMessage in here to be consistent with the other commands that share a message struct, here are three examples:
- https://github.com/minio/mc/blob/master/cmd/admin-user-add.go#L93-L102
- https://github.com/minio/mc/blob/master/cmd/admin-group-add.go#L66-L74
- https://github.com/minio/mc/blob/master/cmd/ilm-tier-add.go#L346-L356
I am totally happy to move it, just give me the 👍 and ack that it makes it inconsistent with the rest of the commands.
Could also make a follow up PR to move them all. I don't know why it's like this.
marktheunissen
force-pushed
the
bucketcors-commands
branch
3 times, most recently
from
d03d0bc to
8c10b67
Compare
klauspost
reviewed
Aug 21, 2024
marktheunissen
force-pushed
the
bucketcors-commands
branch
from
8c10b67 to
1e53784
Compare
harshavardhana
approved these changes
Aug 22, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Add the following commands:
mc cors setmc cors removemc cors getMotivation and Context
These will work with S3 and MinEOS
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)