Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow cat to take part by part numbers #5026

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

harshavardhana
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

allow cat to take part by part numbers

Motivation and Context

this allows for downloading different parts
by part numbers.

How to test this PR?

Upload a multipart object and then specify

mc cat --part-number=2 alias/bucket/bigfile

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Sorry, something went wrong.

Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but just curious about when you want to use this. It looks like we can find the number of parts from the Etag?

Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana merged commit 2e10255 into minio:master Aug 26, 2024
5 checks passed
@harshavardhana
Copy link
Member Author

LGTM, but just curious about when you want to use this. It looks like we can find the number of parts from the Etag?

It is useful when you want to download specific part numbers, to test "decryption" per part. It was used in a customer environment to uncover a bug.

@harshavardhana harshavardhana deleted the support-part-number branch August 26, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants