Update to print skipped entities during IAM import #5032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
harshavardhana
requested changes
Sep 5, 2024
Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
Comment on lines
+218
to
+221
| if e != nil { | ||
| e = client.ImportIAM(context.Background(), f) | ||
| fatalIf(probe.NewError(e).Trace(aliasedURL), "Unable to import IAM info.") | ||
| } else { |
There was a problem hiding this comment.
please test this with previous minio versions, so that this fallback works properly.
harshavardhana
approved these changes
Sep 5, 2024
shtripat
added a commit
to shtripat/mc
that referenced
this pull request
Sep 9, 2024
A regression was introduced by minio#5032 where new `mc` with old MinIO wont import the IAM configs properly. Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
harshavardhana
pushed a commit
that referenced
this pull request
Sep 9, 2024
A regression was introduced by #5032 where new `mc` with old MinIO wont import the IAM configs properly. Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Motivation and Context
How to test this PR?
Follow instructions on minio/minio#20352
Types of changes
Checklist:
commit-idorPR #here)