Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirror:Check the source object exists before remove #5149

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dormanze
Copy link
Contributor

@dormanze dormanze commented Feb 24, 2025

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Check whether objects of other versions exist before remove.

Motivation and Context

fix #5139

How to test this PR?

1.Creating a Bucket and Enabling Versioning Control

mc mb myminio/bucket --with-versioning

2.Start the mirror process.

mc mirror --overwrite --remove --watch myminio/bucket /local/

3.Upload the object to the bucket twice.

mc cp test.txt myminio/bucket/
mc cp test.txt myminio/bucket/

4.Delete an object based on the version number.

mc rm myminio/bucket/test.txt --version-id xxxxxx

Check whether local files are deleted.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mc mirror --remove --watch removes a file when a non-current version of the object is removed
1 participant