Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Project dependencies #830

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Jun 5, 2024

What does this do?

  • Updated Storybook to v8.1.5
  • Updated other dependencies

prakashsvmx
prakashsvmx previously approved these changes Jun 5, 2024
@kaankabalak
Copy link
Collaborator

The workflow seems to be failing with the following message:

src/index.ts → dist/esm/index.js...
[!] (plugin typescript) RollupError: [plugin typescript] src/components/DataTable/ColumnsSelector.tsx (21:30): @rollup/plugin-typescript TS7016: Could not find a declaration file for module 'react-dom'. '/home/runner/work/mds/mds/node_modules/react-dom/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/react-dom` if it exists or add a new declaration (.d.ts) file containing `declare module 'react-dom';`
src/components/DataTable/ColumnsSelector.tsx (21:30)

21 import { createPortal } from "react-dom";
                                ~~~~~~~~~~~

    at getRollupError (/home/runner/work/mds/mds/node_modules/rollup/dist/shared/parseAst.js:282:41)
    at Object.error (/home/runner/work/mds/mds/node_modules/rollup/dist/shared/parseAst.js:278:42)
    at Object.error (/home/runner/work/mds/mds/node_modules/rollup/dist/shared/rollup.js:804:32)
    at emitDiagnostic (file:///home/runner/work/mds/mds/node_modules/@rollup/plugin-typescript/dist/es/index.js:533:17)
    at reportDiagnostics (file:///home/runner/work/mds/mds/node_modules/@rollup/plugin-typescript/dist/es/index.js:541:9)
    at Array.forEach (<anonymous>)
    at emitFilesAndReportErrors (/home/runner/work/mds/mds/node_modules/typescript/lib/typescript.js:[12](https://github.com/minio/mds/actions/runs/9376804540/job/25817347058?pr=830#step:6:13)7124:17)
    at Object.result.afterProgramCreate (/home/runner/work/mds/mds/node_modules/typescript/lib/typescript.js:127283:7)
    at Object.afterProgramCreate (file:///home/runner/work/mds/mds/node_modules/@rollup/plugin-typescript/dist/es/index.js:698:29)
    at synchronizeProgram (/home/runner/work/mds/mds/node_modules/typescript/lib/typescript.js:127652:[14](https://github.com/minio/mds/actions/runs/9376804540/job/25817347058?pr=830#step:6:15))


error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

@bexsoft bexsoft marked this pull request as draft June 5, 2024 01:44
- Updated Storybook to v8.1.5
- Updated other dependencies

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
@bexsoft bexsoft force-pushed the update-deps-4062024 branch from a02843a to 8bb4b30 Compare June 5, 2024 01:49
@bexsoft bexsoft marked this pull request as ready for review June 5, 2024 01:51
@bexsoft
Copy link
Collaborator Author

bexsoft commented Jun 5, 2024

The workflow seems to be failing with the following message:

src/index.ts → dist/esm/index.js...
[!] (plugin typescript) RollupError: [plugin typescript] src/components/DataTable/ColumnsSelector.tsx (21:30): @rollup/plugin-typescript TS7016: Could not find a declaration file for module 'react-dom'. '/home/runner/work/mds/mds/node_modules/react-dom/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/react-dom` if it exists or add a new declaration (.d.ts) file containing `declare module 'react-dom';`
src/components/DataTable/ColumnsSelector.tsx (21:30)

21 import { createPortal } from "react-dom";
                                ~~~~~~~~~~~

    at getRollupError (/home/runner/work/mds/mds/node_modules/rollup/dist/shared/parseAst.js:282:41)
    at Object.error (/home/runner/work/mds/mds/node_modules/rollup/dist/shared/parseAst.js:278:42)
    at Object.error (/home/runner/work/mds/mds/node_modules/rollup/dist/shared/rollup.js:804:32)
    at emitDiagnostic (file:///home/runner/work/mds/mds/node_modules/@rollup/plugin-typescript/dist/es/index.js:533:17)
    at reportDiagnostics (file:///home/runner/work/mds/mds/node_modules/@rollup/plugin-typescript/dist/es/index.js:541:9)
    at Array.forEach (<anonymous>)
    at emitFilesAndReportErrors (/home/runner/work/mds/mds/node_modules/typescript/lib/typescript.js:[12](https://github.com/minio/mds/actions/runs/9376804540/job/25817347058?pr=830#step:6:13)7124:17)
    at Object.result.afterProgramCreate (/home/runner/work/mds/mds/node_modules/typescript/lib/typescript.js:127283:7)
    at Object.afterProgramCreate (file:///home/runner/work/mds/mds/node_modules/@rollup/plugin-typescript/dist/es/index.js:698:29)
    at synchronizeProgram (/home/runner/work/mds/mds/node_modules/typescript/lib/typescript.js:127652:[14](https://github.com/minio/mds/actions/runs/9376804540/job/25817347058?pr=830#step:6:15))


error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

Seems like the types dependencies for react-dom are not longer shipped with the same package. Added in this PR as well

@bexsoft bexsoft merged commit cba52a6 into minio:master Jun 5, 2024
1 check passed
@bexsoft bexsoft deleted the update-deps-4062024 branch June 5, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants