This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
Add multiarch docker options #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @meyskens - Sorry to inform you we will be deprecating this project. We will still accept this PR though. |
|
@meyskens looks like there are conflicts now from recent merge. can you update the PR? |
|
@harshavardhana sad to see this being deprecated :( Any alternatives you can suggest? |
@meyskens yes the alternative is We will deprecate MinFS once we have rexray documented. Thanks for rebasing the PR. |
harshavardhana
approved these changes
Sep 25, 2017
nitisht
approved these changes
Sep 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to specify the architecture which to use in the Docker build. This allows for the plugin to be used on multiple platforms.
For release this should use a Manifest (https://github.com/estesp/manifest-tool, hopefully soon inside Docker itself) but I was unable to find where this is being built.
Feedback welcome!