Fix progress timing for PutObject_Test9 test (fixes #1078)
#1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
previously approved these changes
May 18, 2024
ebozduman
requested changes
May 19, 2024
Collaborator
ebozduman
left a comment
ebozduman
left a comment
There was a problem hiding this comment.
There are 3 more instances of old new Progress(<ProgressReport>(... that need to be replaced with new SyncProgress(<ProgressReport>(...
in 3 files:
- API.md
- Program.cs (Functional)
- FunctionalTest.cs
Contributor
Author
|
@ebozduman I've fixed the occurences in most places, but I didn't replace the implementation in the API description. I did describe the implications of |
harshavardhana
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes timing issue when running progress test. I have introduced a
SyncProgressclass that invokes progress updates synchronously and on the thread that is currently executing. Although not suitable for UI applications (that require UI updates to be done on the main-thread), it's perfectly fine for other situations.