Skip to content

Conversation

@lukashev-di
Copy link
Contributor

@lukashev-di lukashev-di commented Dec 7, 2022

Fixes issue #717

Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukashev-di

Please add a new functional test for this new feature.
You can have one based on one of the PutObject_Test<N> tests in FunctionalTest.cs file.

Also run dotnet regitlint just before you create your commit to be able to include the lint changes in your commit. This will fix the Linux build failure.

Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to make sure the progress is printed out as 100 when a small object/file (<5MB, i.e. not multipart) is uploaded. The progress shows 0 percent after uploading a file < 5MB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants