Skip to content

Conversation

@martijn00
Copy link
Contributor

@ebozduman can you run and check this PR?

@martijn00
Copy link
Contributor Author

@ebozduman it seems to run! Can you merge?

@ebozduman
Copy link
Collaborator

ebozduman commented Aug 26, 2023

@martijn00

The build failure is not because of the latest lint changes.
The failing tests are GetObjectS3Zip_Test1, BucketLifecycleAsync_Test1.1, and GetObject_AsyncCallback_Test1. So, they are totally unrelated.
I also confirmed it by undoing the last check-in, the lint changes, and the same 3 functional tests still fail the same way. This issue is one I am currently working on, PR #844.
PR #844 resolves the duration calculation issue, but there is another failure revealed after that and I am looking into it.
So, as soon as PR #844 is merged, this one can be rebased and merged.

NOTE:
The reason for the Bucket Lifecycle tests to pass sometimes, I think, is because of the Math.Floor function used in the old code,

    Assert.AreEqual(Math.Floor((lfcDate - compareDate).TotalDays), expInDays);

I think we can merge this PR when the build tests pass as the Lifecycle issue has nothing got to do with the changes this PR brings. I'll run the functional tests again tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants