Skip to content

Fix inheritance and add servicecollection #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ebozduman merged 3 commits into from
Aug 29, 2023
Merged

Fix inheritance and add servicecollection #850

ebozduman merged 3 commits into from
Aug 29, 2023

Conversation

@martijn00
Copy link
Contributor

@martijn00 martijn00 commented Aug 25, 2023

@ebozduman
Copy link
Collaborator

ebozduman commented Aug 28, 2023

@martijn00 ,

Will do the review in during CA work hours...

ebozduman
ebozduman reviewed Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martijn00

Could you add some explanation/information about this PR, like what inheritance issue is fixed by this PR and why service collection is added, what is it going to help/solve etc, briefly in just one or two sentences?

@martijn00
Copy link
Contributor Author

martijn00 commented Aug 28, 2023

The IMinioClient interface didn't inherit the 2 other interfaces, but the implementation did implement them. For that reason the methods in the interface were also duplicated. I've removed that.

I'm now working towards a more interface based implementation of minio so that it the standard DI container of .net can use it.

This is a first step towards an easier way to implement Minio. You can call AddMinio in your normal api build and resolve IMinioClient or IMinioClientFactory through DI or the service locator after that

ebozduman
ebozduman approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebozduman ebozduman merged commit 5ea7303 into minio:master Aug 29, 2023
@ebozduman ebozduman mentioned this pull request Aug 29, 2023
Merged
@dependabot dependabot bot mentioned this pull request Dec 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebozduman ebozduman ebozduman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@martijn00 @ebozduman