Skip to content

fixes BucketExists' return value and StatObject's returned exceptions #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ebozduman merged 9 commits into from
Jan 24, 2024
Merged

fixes BucketExists' return value and StatObject's returned exceptions #987

ebozduman merged 9 commits into from
Jan 24, 2024

Conversation

@ebozduman
Copy link
Collaborator

@ebozduman ebozduman commented Jan 22, 2024

Fixes #953, #947, #945

Tested thee fix for the following error cases:

 - StatObjectAsync fails when object does not exist => ObjectNotFoundException
 - StatObjectAsync fails when bucket does not exist => BucketNotFoundException
 - BucketExistsAsync returns true/false

@ebozduman ebozduman changed the title fixes error messages for BucketExists and StatObject fixes BucketExists' return value and StatObject Jan 22, 2024
@ebozduman ebozduman changed the title fixes BucketExists' return value and StatObject fixes BucketExists' return value and StatObject returned exceptions Jan 22, 2024
@ebozduman ebozduman changed the title fixes BucketExists' return value and StatObject returned exceptions fixes BucketExists' return value and StatObject's returned exceptions Jan 22, 2024
shtripat
shtripat reviewed Jan 22, 2024
View reviewed changes
Copy link

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor ones

shtripat
shtripat previously approved these changes Jan 23, 2024
View reviewed changes
@ebozduman ebozduman merged commit 9772a37 into minio:master Jan 24, 2024
@ebozduman ebozduman deleted the test-bucket-exists branch January 24, 2024 05:32
@ebozduman ebozduman mentioned this pull request Feb 5, 2024
Closed
@holterbades holterbades mentioned this pull request Apr 18, 2024
Closed
@marvin-serp-bot marvin-serp-bot mentioned this pull request Feb 5, 2025
Closed
1 task
@dependabot dependabot bot mentioned this pull request Nov 13, 2025
Open
@dependabot dependabot bot mentioned this pull request Dec 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shtripat shtripat shtripat approved these changes

Assignees

No one assigned

Labels

priority: medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

StatObjectAsync does not throw exception when object or bucket does not exist

2 participants

@ebozduman @shtripat