credentials: support AWS_CONTAINER_CREDENTIALS_FULL_URI #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ribbybibby can you pls check the travis failure |
This environment variable allows the definiton of a full URI to an ECS task endpoint on a loopback address. It is documented sparsely compared to AWS_CONTAINER_CREDENTIALS_RELATIVE_URI but is implemented in every major AWS SDK. See: - https://github.com/aws/aws-sdk-go/blob/master/aws/defaults/defaults.go#L117 - https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/ECSCredentials.html - https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/auth/EC2ContainerCredentialsProviderWrapper.html
|
@nitisht I think the failure was actually an 'error'; the build didn't seem to start for some reason. Regardless, I've rebased against master which has triggered a passing build. |
nitisht
approved these changes
Nov 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This environment variable allows the definiton of a full URI that points to an ECS task endpoint on a loopback address.
It is documented sparsely compared to
AWS_CONTAINER_CREDENTIALS_RELATIVE_URIbut is implemented in every major AWS SDK.See: