-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bucket tagging apis #1273
Merged
harshavardhana
merged 3 commits into
minio:master
from
balamurugana:add-bucket-tagging-apis
Apr 28, 2020
Merged
add bucket tagging apis #1273
harshavardhana
merged 3 commits into
minio:master
from
balamurugana:add-bucket-tagging-apis
Apr 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisis
previously approved these changes
Apr 20, 2020
kannappanr
reviewed
Apr 21, 2020
balamurugana
force-pushed
the
add-bucket-tagging-apis
branch
2 times, most recently
from
April 25, 2020 06:38
4885f51
to
00086fd
Compare
balamurugana
force-pushed
the
add-bucket-tagging-apis
branch
from
April 25, 2020 08:18
00086fd
to
3bb9e0e
Compare
kannappanr
previously approved these changes
Apr 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you also please add documentation and examples as part of adding a new API? |
BigUstad
previously approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
krisis
previously approved these changes
Apr 27, 2020
balamurugana
dismissed stale reviews from krisis, BigUstad, and kannappanr
via
April 28, 2020 05:39
46e1e53
harshavardhana
approved these changes
Apr 28, 2020
krisis
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1275