Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bucket tagging apis #1273

Merged
merged 3 commits into from
Apr 28, 2020

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Apr 19, 2020

depends on #1275

krisis
krisis previously approved these changes Apr 20, 2020
api-bucket-tagging.go Outdated Show resolved Hide resolved
@balamurugana balamurugana force-pushed the add-bucket-tagging-apis branch 2 times, most recently from 4885f51 to 00086fd Compare April 25, 2020 06:38
@balamurugana balamurugana force-pushed the add-bucket-tagging-apis branch from 00086fd to 3bb9e0e Compare April 25, 2020 08:18
kannappanr
kannappanr previously approved these changes Apr 26, 2020
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr
Copy link
Collaborator

Can you also please add documentation and examples as part of adding a new API?

BigUstad
BigUstad previously approved these changes Apr 27, 2020
Copy link
Contributor

@BigUstad BigUstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

krisis
krisis previously approved these changes Apr 27, 2020
@balamurugana balamurugana dismissed stale reviews from krisis, BigUstad, and kannappanr via 46e1e53 April 28, 2020 05:39
@harshavardhana harshavardhana merged commit c350b2e into minio:master Apr 28, 2020
@balamurugana balamurugana deleted the add-bucket-tagging-apis branch April 28, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants