Add custom MD5/SHA256 hasher option #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there is no cleanup for the API clients using the SIMD MD5 needs to be up to the API users to manage. Provide a function that allows to insert a custom hasher. md5-simd package is only used to provide the interface, by default a wrapper for "crypto/md5" is created, so default performance remains unaffected.
klauspost
added a commit
to klauspost/warp
that referenced
this pull request
May 4, 2020
Bonus changes: * Compress output a bit better * Clean up put options * Move `disable-multipart` to IO options * Add comment value for CSV input, so we can add stuff like cmdline to output later. Waiting for minio/minio-go#1283
|
Code looks good, but need to sort of the md5-simd buffer copy issue first. |
Do we need it anymore? @klauspost |
* Allow custom sha256. * Add a pool for sha256 and md5 and reuse them.
klauspost
changed the title
|
@harshavardhana I have kept the default to be a wrapped stdlib, but added a wrapper that will allow reuse of the hashers. I think this will be a fine improvement and it gives the flexibility to override them on clients. |
harshavardhana
approved these changes
Jun 2, 2020
|
PTAL @fwessels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is no cleanup for the API clients using the SIMD MD5 needs to be up to the API users to manage.
Provide a function that allows to insert a custom hasher for MD5 and SHA256.
We keep using the same for both, but by default we allow to reuse the hashers.