fix canonical header computation for multi-spaced header values #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
force-pushed
the
fix-canonical-header-computation-for-multi-spaced-header-values
branch
3 times, most recently
from
c6a98c4
to
05aa021
Compare
|
@balamurugana Please take a look at the CI failure |
harshavardhana
requested changes
Jul 22, 2020
harshavardhana
requested changes
Jul 22, 2020
There was a problem hiding this comment.
As per canonical header generation pattern, the adjacent spaces should be trimmed for signature calculation
https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html
balamurugana
force-pushed
the
fix-canonical-header-computation-for-multi-spaced-header-values
branch
from
05aa021
to
84d4a72
Compare
harshavardhana
approved these changes
Jul 23, 2020
balamurugana
deleted the
fix-canonical-header-computation-for-multi-spaced-header-values
branch
harshavardhana
pushed a commit
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.