Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more validation in lifecycle configuration class #1106

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Add more validation in lifecycle configuration class #1106

merged 2 commits into from
Nov 26, 2020

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Nov 8, 2020 •
edited
Loading

No description provided.

@balamurugana balamurugana marked this pull request as draft November 8, 2020 11:41
@balamurugana balamurugana force-pushed the add-more-validation-in-LifecycleConfiguration-class branch from 29dd874 to b610c79 Compare November 25, 2020 03:22
@balamurugana balamurugana marked this pull request as ready for review November 25, 2020 03:22
@balamurugana balamurugana force-pushed the add-more-validation-in-LifecycleConfiguration-class branch from b610c79 to 825c124 Compare November 26, 2020 04:36
anjalshireesh
anjalshireesh previously approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minior comment

api/src/main/java/io/minio/messages/LifecycleRule.java Outdated Show resolved Hide resolved
anjalshireesh
anjalshireesh approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit de9ca1c into minio:master Nov 26, 2020
@balamurugana balamurugana deleted the add-more-validation-in-LifecycleConfiguration-class branch November 26, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjalshireesh anjalshireesh anjalshireesh approved these changes

@Praveenrajmani Praveenrajmani Praveenrajmani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balamurugana @anjalshireesh @Praveenrajmani @kannappanr