Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use junit in functional tests #1133

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Use junit in functional tests #1133

merged 1 commit into from
Dec 22, 2020

Conversation

balamurugana
Copy link
Member

No description provided.

ebozduman
ebozduman requested changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@ebozduman ebozduman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My functional test run fails.
I'll find out what is wrong in my environment since these tests are passing in CI.

functional/FunctionalTest.java Show resolved Hide resolved
functional/FunctionalTest.java Show resolved Hide resolved
functional/FunctionalTest.java Show resolved Hide resolved
functional/FunctionalTest.java Show resolved Hide resolved
functional/FunctionalTest.java Show resolved Hide resolved
functional/FunctionalTest.java Show resolved Hide resolved
functional/FunctionalTest.java Show resolved Hide resolved
functional/FunctionalTest.java Show resolved Hide resolved
functional/FunctionalTest.java Show resolved Hide resolved
functional/FunctionalTest.java Show resolved Hide resolved
ebozduman
ebozduman approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kannappanr
kannappanr approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr removed the request for review from BigUstad December 22, 2020 20:45
@kannappanr kannappanr merged commit 3d95b5c into minio:master Dec 22, 2020
@balamurugana balamurugana deleted the use-junit-in-functional-tests branch December 23, 2020 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebozduman ebozduman ebozduman approved these changes

@kannappanr kannappanr kannappanr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balamurugana @ebozduman @kannappanr