Add preload data support for putObject() API. #1156
Conversation
When this flag is enabled, entire part/object data is loaded into memory to enable connection retry on network failure in the middle of upload.
| @@ -3807,6 +3815,25 @@ private long getAvailableSize(Object data, long expectedReadSize) | |||
| return totalBytesRead; | |||
| } | |||
|
|
|||
| private void fillData(ByteArrayOutputStream buffer, Object data, long size) throws IOException { | |||
There was a problem hiding this comment.
Since this looks like a generic method to fill a given output stream, can it be moved to some utility class outside MinioClient?
There was a problem hiding this comment.
It is not generic method, it is specifically designed and used to MinioClient
There was a problem hiding this comment.
The code is very much generic - there is nothing specific to MinioClient in it and can definitely be used from other places if required in future.
Even if you consider it MinioClient specific, we can still have something like MinioClientUtil. The MinioClient.java is too huge for comfort (5000+ lines)
There was a problem hiding this comment.
This is different issue, needs to be addressed in different PR.
There was a problem hiding this comment.
Your call. IMHO it's a good idea to start straight away, especially for new methods that are being introduced.
When this flag is enabled, entire part/object data is loaded into memory to
enable connection retry on network failure in the middle of upload.