Docs and examples added for Object Lock #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanagarajkm
previously approved these changes
Sep 30, 2019
kannappanr
reviewed
Oct 1, 2019
docs/API.md
Outdated
| |:--- |:--- | | ||
| | ``None`` | Listed Exceptions: | | ||
| | | ``InvalidBucketNameException`` : upon invalid bucket name. | | ||
| | | ``RegionConflictException`` : upon passed region conflicts with the one previously specified. | |
There was a problem hiding this comment.
Instead of RegionConflictException you should talk about InvalidArgumentException as that is what is being thrown in the code.
kannappanr
reviewed
Oct 1, 2019
docs/API.md
Outdated
| |:--- |:--- | | ||
| | ``None`` | Listed Exceptions: | | ||
| | | ``InvalidBucketNameException`` : upon invalid bucket name. | | ||
| | | ``RegionConflictException`` : upon passed region conflicts with the one previously specified. | |
There was a problem hiding this comment.
Instead of RegionConflictException you should talk about InvalidArgumentException as that is what is being thrown in the code.
kannappanr
requested changes
Oct 1, 2019
sinhaashish
force-pushed
the
docs-update-object-lock
branch
from
dda71ca
to
aef5deb
Compare
Thanks for pointing this out . Removed |
sinhaashish
force-pushed
the
docs-update-object-lock
branch
from
aef5deb
to
daced3b
Compare
sinhaashish
force-pushed
the
docs-update-object-lock
branch
from
daced3b
to
d2ade2b
Compare
kanagarajkm
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs updated with below api:
public void makeBucket(String bucketName, String region, boolean objectLock)
public void enableVersioning(String bucketName)
public void disableVersioning(String bucketName)
public void setDefaultRetention(String bucketName, ObjectLockConfiguration config)
public ObjectLockConfiguration getDefaultRetention(String bucketName)
Examples added for make bucket with lock and set/get object lock configuration.