-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs and examples added for Object Lock #800
Conversation
docs/API.md
Outdated
|:--- |:--- | | ||
| ``None`` | Listed Exceptions: | | ||
| | ``InvalidBucketNameException`` : upon invalid bucket name. | | ||
| | ``RegionConflictException`` : upon passed region conflicts with the one previously specified. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of RegionConflictException
you should talk about InvalidArgumentException
as that is what is being thrown in the code.
docs/API.md
Outdated
|:--- |:--- | | ||
| ``None`` | Listed Exceptions: | | ||
| | ``InvalidBucketNameException`` : upon invalid bucket name. | | ||
| | ``RegionConflictException`` : upon passed region conflicts with the one previously specified. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of RegionConflictException you should talk about InvalidArgumentException as that is what is being thrown in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please incorporate the changes requested in the comments.
dda71ca
to
aef5deb
Compare
Thanks for pointing this out . Removed |
aef5deb
to
daced3b
Compare
daced3b
to
d2ade2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Docs updated with below api:
public void makeBucket(String bucketName, String region, boolean objectLock)
public void enableVersioning(String bucketName)
public void disableVersioning(String bucketName)
public void setDefaultRetention(String bucketName, ObjectLockConfiguration config)
public ObjectLockConfiguration getDefaultRetention(String bucketName)
Examples added for make bucket with lock and set/get object lock configuration.