fix windows ci #813
Merged
fix windows ci #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@balamurugana as you mentioned in #811 (comment) |
Closed
balamurugana
approved these changes
Nov 8, 2019
harshavardhana
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix windows ci
Problem:
It seems that
gradlew.batis not operable in the original windows-ci.See a failed check in #811:
https://github.com/minio/minio-java/pull/811/checks?check_run_id=292192553
#811 did nothing but improve some docs, but it still failed in windows-ci.
Fix:
Include current folder in
Path.P.S. I don't understand why windows-ci was ok before but failed recently.
How to Test:
See #814 which is just #811 with current folder in
Path==> ci passed.Ref:
https://stackoverflow.com/a/9046942/5898846