Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance returned object of listenBucketNotification() #867

Merged
merged 1 commit into from
Mar 25, 2020
Merged

enhance returned object of listenBucketNotification() #867

merged 1 commit into from
Mar 25, 2020

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Mar 18, 2020 •
edited
Loading

No description provided.

@harshavardhana
Copy link
Member

@balamurugana we are planning for a release on Monday, is this required to be in?

@balamurugana
Copy link
Member Author

@balamurugana we are planning for a release on Monday, is this required to be in?

It depends on how deprecating current listenBucketNotification(). @kannappanr is checking on it.

@balamurugana balamurugana force-pushed the enhance-returned-object-of-listenBucketNotification branch 3 times, most recently from a8b99dd to 9019c4d Compare March 22, 2020 05:06
@balamurugana balamurugana force-pushed the enhance-returned-object-of-listenBucketNotification branch from 9019c4d to 0e2f5e8 Compare March 25, 2020 06:32
@kannappanr kannappanr requested a review from nitisht March 25, 2020 07:45
kannappanr
kannappanr approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nitisht
nitisht approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 143646c into minio:master Mar 25, 2020
@balamurugana balamurugana deleted the enhance-returned-object-of-listenBucketNotification branch March 25, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitisht nitisht nitisht approved these changes

@kannappanr kannappanr kannappanr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balamurugana @harshavardhana @nitisht @kannappanr