Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add arg builder to {set,get,delete}BucketLifeCycle APIs #931

Merged
merged 1 commit into from
May 27, 2020
Merged

add arg builder to {set,get,delete}BucketLifeCycle APIs #931

merged 1 commit into from
May 27, 2020

Conversation

balamurugana
Copy link
Member

No description provided.

@balamurugana balamurugana force-pushed the add-arg-builder-to-set-get-delete-BucketLifeCycle-APIs branch 4 times, most recently from 7fd2ae2 to c29285d Compare May 22, 2020 07:00
sinhaashish
sinhaashish previously approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & LGTM

@kannappanr
Copy link
Contributor

Please resolve the conflicts Bala, otherwise LGTM

@balamurugana balamurugana force-pushed the add-arg-builder-to-set-get-delete-BucketLifeCycle-APIs branch from c29285d to 39e8464 Compare May 26, 2020 10:07
BigUstad
BigUstad previously approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@BigUstad BigUstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM

@balamurugana balamurugana force-pushed the add-arg-builder-to-set-get-delete-BucketLifeCycle-APIs branch from 39e8464 to 96759bc Compare May 27, 2020 03:13
kannappanr
kannappanr approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sinhaashish
sinhaashish approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 78c9781 into minio:master May 27, 2020
@balamurugana balamurugana deleted the add-arg-builder-to-set-get-delete-BucketLifeCycle-APIs branch May 27, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinhaashish sinhaashish sinhaashish approved these changes

@kannappanr kannappanr kannappanr approved these changes

@BigUstad BigUstad BigUstad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balamurugana @kannappanr @sinhaashish @BigUstad