Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add arg builder to listenBucketNotification API #934

Merged
merged 2 commits into from
Jun 2, 2020
Merged

add arg builder to listenBucketNotification API #934

merged 2 commits into from
Jun 2, 2020

Conversation

balamurugana
Copy link
Member

No description provided.

@balamurugana balamurugana mentioned this pull request May 14, 2020
Merged
@balamurugana balamurugana force-pushed the add-arg-builder-to-listenBucketNotification-API branch 5 times, most recently from c4dc9e6 to 9b6ef60 Compare May 22, 2020 06:40
@balamurugana balamurugana force-pushed the add-arg-builder-to-listenBucketNotification-API branch 6 times, most recently from b322eef to 6a22133 Compare May 31, 2020 05:16
anjalshireesh
anjalshireesh previously approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment

functional/FunctionalTest.java Outdated Show resolved Hide resolved
@balamurugana balamurugana force-pushed the add-arg-builder-to-listenBucketNotification-API branch from 6a22133 to 7aaadc6 Compare June 1, 2020 16:00
@balamurugana balamurugana force-pushed the add-arg-builder-to-listenBucketNotification-API branch from 50737a7 to 24fb90f Compare June 2, 2020 06:53
@balamurugana balamurugana force-pushed the add-arg-builder-to-listenBucketNotification-API branch from 24fb90f to 9f9b428 Compare June 2, 2020 06:57
anjalshireesh
anjalshireesh approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sinhaashish
sinhaashish approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana merged commit 6ccfa09 into minio:master Jun 2, 2020
@balamurugana balamurugana deleted the add-arg-builder-to-listenBucketNotification-API branch June 2, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjalshireesh anjalshireesh anjalshireesh approved these changes

@sinhaashish sinhaashish sinhaashish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balamurugana @anjalshireesh @sinhaashish