Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add arg builder support to copyObject API #970

Merged
merged 3 commits into from
Jun 10, 2020
Merged

add arg builder support to copyObject API #970

merged 3 commits into from
Jun 10, 2020

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Jun 5, 2020 •
edited
Loading

No description provided.

@balamurugana balamurugana force-pushed the add-arg-builder-support-to-copyObject-API branch 5 times, most recently from 0ccfcdb to c894892 Compare June 5, 2020 18:16
@balamurugana balamurugana marked this pull request as draft June 5, 2020 18:16
@balamurugana balamurugana force-pushed the add-arg-builder-support-to-copyObject-API branch 5 times, most recently from 030788e to 466aded Compare June 7, 2020 03:19
@balamurugana balamurugana mentioned this pull request Jun 7, 2020
Merged
@balamurugana balamurugana force-pushed the add-arg-builder-support-to-copyObject-API branch from 466aded to 3a9281d Compare June 7, 2020 03:39
@balamurugana balamurugana marked this pull request as ready for review June 7, 2020 03:39
@balamurugana balamurugana force-pushed the add-arg-builder-support-to-copyObject-API branch 3 times, most recently from a99429e to 82d45dc Compare June 8, 2020 09:45
@balamurugana balamurugana force-pushed the add-arg-builder-support-to-copyObject-API branch from 82d45dc to 6288dcb Compare June 9, 2020 02:14
sinhaashish
sinhaashish previously approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anjalshireesh
anjalshireesh requested changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments.
Love that this PR removes more code than it adds 😄

api/src/main/java/io/minio/ObjectWriteArgs.java Show resolved Hide resolved
api/src/main/java/io/minio/ObjectWriteArgs.java Outdated Show resolved Hide resolved
api/src/main/java/io/minio/MinioClient.java Outdated Show resolved Hide resolved
api/src/main/java/io/minio/MinioClient.java Outdated Show resolved Hide resolved
functional/FunctionalTest.java Outdated Show resolved Hide resolved
anjalshireesh
anjalshireesh approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sinhaashish
sinhaashish approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana merged commit 928cfef into minio:master Jun 10, 2020
@balamurugana balamurugana deleted the add-arg-builder-support-to-copyObject-API branch June 10, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjalshireesh anjalshireesh anjalshireesh approved these changes

@sinhaashish sinhaashish sinhaashish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balamurugana @anjalshireesh @sinhaashish