Add base argument class for conditionally reading objects. #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
force-pushed
the
Add-base-argument-class-for-conditionally-reading-objects
branch
2 times, most recently
from
5f4a9dd
to
756da23
Compare
sinhaashish
reviewed
Jun 24, 2020
| public class StatObjectArgs extends ObjectConditionalReadArgs { | ||
| protected StatObjectArgs() {} | ||
|
|
||
| public StatObjectArgs(ObjectConditionalReadArgs args) { |
There was a problem hiding this comment.
As the name suggest StatObjectArgs is an builder type then why is the constructor used. IMO it should be renamed to StatObject similar to ComposeObject.
kannappanr
reviewed
Jun 25, 2020
kannappanr
reviewed
Jun 25, 2020
`GetObject`, `HeadObject` and `CopyObject` S3 API support conditions on reading objects. This patch introduces common base class `ObjectConditionalReadArgs` for `GetObjectArgs`, `StatObjectArgs`, `CopySource` and `ComposeSource` to avoid code duplication.
balamurugana
force-pushed
the
Add-base-argument-class-for-conditionally-reading-objects
branch
from
756da23
to
6f7c7e6
Compare
balamurugana
deleted the
Add-base-argument-class-for-conditionally-reading-objects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetObject,HeadObjectandCopyObjectS3 API support conditionson reading objects. This patch introduces common base class
ObjectConditionalReadArgsforGetObjectArgs,StatObjectArgs,CopySourceandComposeSourceto avoid code duplication.