-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sts client grants #996
Sts client grants #996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Could you adapt credentials framework like in minio-py ?
- We do not use
get<PROPERTY>()
for getters instead just<PROPERTY>()
and make property immutable.
api/src/main/java/io/minio/messages/AssumeRoleWithClientGrantsResponse.java
Outdated
Show resolved
Hide resolved
@balamurugana 1. i'm not sure, i'll take a look at wednesday or sunday, ok? |
hi, @balamurugana |
Can you make those automatic changes into separate PR? Also you could add how it is generated in the description. |
I mean i made that changes instinctively during minio client update =D (like removing unnecessary boxing etc...) |
@egetman Can you add copyright to newly added files before we start review? |
@egetman all of them |
api/src/main/java/io/minio/credentials/AnonymousCredentialsProvider.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial basic review.
api/src/main/java/io/minio/credentials/AnonymousCredentialsProvider.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/minio/credentials/CredentialsProvider.java
Outdated
Show resolved
Hide resolved
@egetman Please make a separate PR for changes not related to credentials in |
/** | ||
* @return a valid (not expired) {@link Credentials} instance for {@link io.minio.MinioClient}. | ||
*/ | ||
Credentials fetch(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could refer minio-py; but it can be brought later if needed.
…de cleanups" This reverts commit c924f49
…ral null-checks in different places.
@balamurugana I'm not a fan of such an api (nullable), but you're the boss. I removed cleanup's from MinioClient. |
@balamurugana Hi! Is there any news about the pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our plan to take this PR as is and modify with subsequent PRs to correctness. Please resolve the conflict.
…nt-grants # Conflicts: # api/src/main/java/io/minio/MinioClient.java
@balamurugana done |
Hey, guys.
I've played a little with an STS api, and figured out that there is no implementation in java sdk.
So i've made one for "client grants".