Sts client grants #996

egetman · 2020-06-29T10:09:30Z

Hey, guys.
I've played a little with an STS api, and figured out that there is no implementation in java sdk.
So i've made one for "client grants".

balamurugana

Could you adapt credentials framework like in minio-py ?
We do not use get<PROPERTY>() for getters instead just <PROPERTY>() and make property immutable.

api/src/main/java/io/minio/messages/AssumeRoleWithClientGrantsResponse.java

egetman · 2020-06-29T13:55:00Z

@balamurugana 1. i'm not sure, i'll take a look at wednesday or sunday, ok?

egetman · 2020-07-01T13:27:46Z

hi, @balamurugana
I've added a few code cleanups, not related to this pr (it was unintentional, automatic =( ), hope that it's ok?

balamurugana · 2020-07-01T13:43:01Z

@egetman

hi, @balamurugana
I've added a few code cleanups, not related to this pr (it was unintentional, automatic =( ), hope that it's ok?

Can you make those automatic changes into separate PR? Also you could add how it is generated in the description.

egetman · 2020-07-01T13:47:23Z

I mean i made that changes instinctively during minio client update =D (like removing unnecessary boxing etc...)

balamurugana · 2020-07-01T13:52:57Z

@egetman Can you add copyright to newly added files before we start review?

harshavardhana · 2020-07-01T23:40:50Z

@balamurugana I find only examples with the copyright labels. Should I add copyrights to all other library-related classes/interfaces?

@egetman all of them

api/src/main/java/io/minio/S3Escaper.java

api/src/main/java/io/minio/credentials/AnonymousCredentialsProvider.java

examples/ClientGrants.java

examples/WebIdentity.java

examples/ClientGrants.java

egetman · 2020-07-02T09:07:50Z

@balamurugana @harshavardhana done

balamurugana

Initial basic review.

api/src/main/java/io/minio/messages/Credentials.java

api/src/main/java/io/minio/messages/WebIdentityToken.java

api/src/main/java/io/minio/credentials/AnonymousCredentialsProvider.java

api/src/main/java/io/minio/credentials/CredentialsProvider.java

api/src/main/java/io/minio/MinioClient.java

balamurugana · 2020-07-02T11:57:33Z

@egetman Please make a separate PR for changes not related to credentials in MinioClient.java. Its hard to review many changes together.

api/src/main/java/io/minio/messages/WebIdentityToken.java

api/src/main/java/io/minio/messages/ClientGrantsToken.java

api/src/main/java/io/minio/messages/Credentials.java

balamurugana · 2020-07-02T14:56:02Z

api/src/main/java/io/minio/credentials/Provider.java

+  /**
+   * @return a valid (not expired) {@link Credentials} instance for {@link io.minio.MinioClient}.
+   */
+  Credentials fetch();


You could refer minio-py; but it can be brought later if needed.

api/src/main/java/io/minio/MinioClient.java

…de cleanups" This reverts commit c924f49

…ral null-checks in different places.

egetman · 2020-07-08T16:39:07Z

@balamurugana I'm not a fan of such an api (nullable), but you're the boss. I removed cleanup's from MinioClient.

egetman · 2020-07-15T12:56:44Z

@balamurugana Hi! Is there any news about the pr?

balamurugana

Our plan to take this PR as is and modify with subsequent PRs to correctness. Please resolve the conflict.

…nt-grants # Conflicts: # api/src/main/java/io/minio/MinioClient.java

egetman · 2020-07-23T16:17:17Z

@balamurugana done

egetman added 8 commits June 28, 2020 14:19

Add sts response messages for client grants

c06ab28

Add struct for access token & token expiration

286d916

Switch ZonedDateTime with wrapper

284369a

Implement base sts client grants functionality

3d2cfec

Add ClientGrants example

ea688da

Fix code style

0b1242e

Add javadocs

d097c82

Update README.md with link to ClientGrants example

42232c6

balamurugana reviewed Jun 29, 2020

View reviewed changes

api/src/main/java/io/minio/messages/AssumeRoleWithClientGrantsResponse.java Outdated Show resolved Hide resolved

Fix getters naming issues

a29e3da

egetman added 15 commits June 30, 2020 16:05

Change S3Escaper sync StrBuffer -> StrBuilder

8ca3cf7

Update STS request/response structures

fb86cf0

Make S3Escaper visible outside the package

eba0ae9

Add basic CredentialsProvider interface

ea299dd

Added a bunch of CredentialsProvider implementations

48950c3

Fix some issues with DCL

e187846

Add WebIdentityCredentialsProvider

c5d8f08

Make Credentials immutable

115599c

Add Token request for WebIdentity

348838c

Update ClientGrants with new api

341fa60

Add WebIdentity example

2b6c19b

Update README.md reference for sts api

4afbcde

Update MinioClient with new CredentialsProvider api. Minor code cleanups

c924f49

Fix code formatting

a350ca7

Update resources host/port in examples

54f4cb8

harshavardhana requested changes Jul 1, 2020

View reviewed changes

balamurugana requested a review from anjalshireesh July 2, 2020 05:22

balamurugana reviewed Jul 2, 2020

View reviewed changes

examples/ClientGrants.java Outdated Show resolved Hide resolved

egetman added 4 commits July 2, 2020 11:55

Remove comments from S3Escaper init

6d63fb2

Update licence year for examples, update sts url's

2b70264

Added license for new files

fac6501

Simplify AwsEnvironmentCredentialsProvider

f6b2776

balamurugana reviewed Jul 2, 2020

View reviewed changes

Some review fixes

3a353de

balamurugana reviewed Jul 2, 2020

View reviewed changes

egetman added 2 commits July 8, 2020 18:21

Revert "Update MinioClient with new CredentialsProvider api. Minor co…

db1f61f

…de cleanups" This reverts commit c924f49

Removed AnonymousProvider, cleanups and some constructors. Added seve…

7458702

…ral null-checks in different places.

egetman added 2 commits July 9, 2020 13:03

Merge remote-tracking branch 'upstream/master'

faf6074

Update pr with upstream

89e9721

egetman requested review from balamurugana and harshavardhana July 9, 2020 11:11

balamurugana previously approved these changes Jul 23, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into sts-client-grants

5f3cfb3

egetman dismissed balamurugana’s stale review via 5f3cfb3 July 23, 2020 15:46

egetman added 2 commits July 23, 2020 18:58

Merge remote-tracking branch 'upstream/master' into sts-client-grants

2217140

Merge remote-tracking branch 'origin/sts-client-grants' into sts-clie…

8384194

…nt-grants # Conflicts: # api/src/main/java/io/minio/MinioClient.java

balamurugana approved these changes Jul 24, 2020

View reviewed changes

harshavardhana approved these changes Jul 24, 2020

View reviewed changes

balamurugana merged commit f1b4011 into minio:master Jul 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sts client grants #996

Sts client grants #996

egetman commented Jun 29, 2020

balamurugana left a comment

egetman commented Jun 29, 2020

egetman commented Jul 1, 2020

balamurugana commented Jul 1, 2020

egetman commented Jul 1, 2020

balamurugana commented Jul 1, 2020

harshavardhana commented Jul 1, 2020

egetman commented Jul 2, 2020

balamurugana left a comment

balamurugana commented Jul 2, 2020

balamurugana Jul 2, 2020

egetman commented Jul 8, 2020

egetman commented Jul 15, 2020

balamurugana left a comment

egetman commented Jul 23, 2020

Sts client grants #996

Sts client grants #996

Conversation

egetman commented Jun 29, 2020

balamurugana left a comment

Choose a reason for hiding this comment

egetman commented Jun 29, 2020

egetman commented Jul 1, 2020

balamurugana commented Jul 1, 2020

egetman commented Jul 1, 2020

balamurugana commented Jul 1, 2020

harshavardhana commented Jul 1, 2020

egetman commented Jul 2, 2020

balamurugana left a comment

Choose a reason for hiding this comment

balamurugana commented Jul 2, 2020

balamurugana Jul 2, 2020

Choose a reason for hiding this comment

egetman commented Jul 8, 2020

egetman commented Jul 15, 2020

balamurugana left a comment

Choose a reason for hiding this comment

egetman commented Jul 23, 2020