how do you pass in credentials for MinioAdmin after the major refactor?

[jessebot]

After #1291, how do you pass in credentials for the MinioAdmin class now? credentials type is not defined here, but is required as there is no default:

minio-py/minio/minioadmin.py

Line 90 in 8e681bb

credentials,

But when I look at the code here, it shows it should be of type Provider:

minio-py/minio/minioadmin.py

Lines 96 to 97 in 8e681bb

	if not isinstance(credentials, Provider):
	raise ValueError("valid credentials must be provided")

However, when I look at Provider, it doesn't explain what type credentials are either:

minio-py/minio/credentials/providers.py

Lines 78 to 84 in 8e681bb

	class Provider: # pylint: disable=too-few-public-methods
	"""Credential retriever."""
	__metaclass__ = ABCMeta
	@abstractmethod
	def retrieve(self):
	"""Retrieve credentials and its expiry if available."""

In the future, before merging and releasing a major refactoring change like this, please require doc and example updates. A deprecation warning would have also been helpful.

For the type hints, I added #1334 to try and help out. If I can get confirmation on how to pass in credentials, I'm happy to create further PRs to update some examples to help out.

[pbrw]

Here is an example:

from minio.credentials import StaticProvider

madmin = MinioAdmin(
     "127.0.0.1:9000",
     credentials=StaticProvider(
         access_key='minioadmin', 
         secret_key='minioadmin'
     ),
     secure=False
)

[jessebot]

awesome, thank you! I'll give that a try and then also try to add some examples in a PR shortly :)

[balamurugana]

Refer #1334

[furkansahin]

I landed here, too. It would be really nice if you had some documentation around MinioAdmin class in general...

[jessebot]

Sorry, the project I'm on right now started demoing an alternative self hosted object store, and then I didn't have time to try out the new suggested workflow. If others have more time and have tested the example in #1331 (comment) please feel free to submit example PRs ahead of me.