Make code property check optional in IamAwsProvider #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@balamurugana what does this fix exactly ? Is there any user experiencing issues ? |
|
@vadmeste Please refer issue minio/minio-java#1108 |
vadmeste
reviewed
Nov 23, 2020
| @@ -387,10 +382,10 @@ def fetch(self, url): | |||
|
|
|||
| res = _urlopen(self._http_client, "GET", url) | |||
| data = json.loads(res.data) | |||
| if data["Code"] != "Success": | |||
| if data.get("Code", "Success") != "Success": | |||
There was a problem hiding this comment.
Maybe let's check for "AccessKeyId", "SecretAccessKey" and "Token" fields, if they are non empty then we can assume this is successful call
There was a problem hiding this comment.
If those fields don't have proper values, it will fail at line no 393. I think this check is good enough to address other cases. However this fix is only testable in AWS ECS env.
krisis
approved these changes
Nov 24, 2020
balamurugana
deleted the
Make-code-property-check-optional-in-IamAwsProvider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.