Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a py.typed file to expose type annotations #1320

Closed
wants to merge 1 commit into from

Conversation

brianhelba
Copy link
Contributor

@trim21
Copy link
Contributor

trim21 commented Nov 4, 2023

should we add this file after package is fully typed?

@brianhelba
Copy link
Contributor Author

I think it'd be beneficial to add now, so downstream packages can start to use the annotations which already exist. Anything without an annotation will just default to Any, which is what happens right now (without py.typed).

I think enabling this might actually help to encourage community contributions to help get this package fully typed, since downstream users will want to add annotations to the APIs which they use.

@balamurugana
Copy link
Member

Refer #1376

@brianhelba brianhelba deleted the py-typed branch December 14, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants