Add type annotations to xml.py #1327
Conversation
trim21
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, which class/function are you referring to? your review comment didn't attach to any line of files. |
Code in xml.py |
done |
| @@ -80,20 +92,43 @@ def findtext(element, name, strict=False): | |||
| return element.text or "" | |||
|
|
|||
|
|
|||
| def unmarshal(cls, xmlstring): | |||
| K = TypeVar("K") | |||
There was a problem hiding this comment.
this is generic type parameter, it's custom to be named as T K J。it's like i x,y in looping.
| data, encoding=None, xml_declaration=False, | ||
| ) | ||
| return data.getvalue() | ||
| with io.BytesIO() as data: |
There was a problem hiding this comment.
Why do we need to use with here?
There was a problem hiding this comment.
close file and discard the buffer.
There was a problem hiding this comment.
There was a problem hiding this comment.
This is not necessary, gc will handle them if we don't use with
There was a problem hiding this comment.
Yep. For this function, it is unnecessary.
| data, encoding=None, xml_declaration=False, | ||
| ) | ||
| return data.getvalue() | ||
| with io.BytesIO() as data: |
There was a problem hiding this comment.
Yep. For this function, it is unnecessary.
No description provided.