Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed iam time delta #935

Merged
merged 10 commits into from
Jul 9, 2020
Merged

Conversation

febg
Copy link
Contributor

@febg febg commented Jun 29, 2020

Subtracts time delta from AWS IAM expiration time.

Tries to solve #934

harshavardhana
harshavardhana previously approved these changes Jun 29, 2020
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, LGTM otherwise

minio/credentials/providers.py Show resolved Hide resolved
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another comment

minio/credentials/providers.py Show resolved Hide resolved
@harshavardhana
Copy link
Member

AttributeError: module 'isort' has no attribute 'SortImports'

when did this start happening?

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana
Copy link
Member

module 'isort' has no attribute

PyCQA/isort#1273 (comment) @febg shall fix this in a separate PR hold on

@vadmeste
Copy link
Member

vadmeste commented Jul 8, 2020

AttributeError: module 'isort' has no attribute 'SortImports'

when did this start happening?

Most likely we had opened PRs that successfully finished CI and we merged them after merging @balamurugana pylint PR

@balamurugana
Copy link
Member

A recent breakage of isort. We may need to upgrade packages as suggested.

@harshavardhana
Copy link
Member

A recent breakage of isort. We may need to upgrade packages as suggested.

Yes sent another PR #937

@harshavardhana harshavardhana merged commit 1ee647e into minio:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants