-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
php: Add GetObject, PutObject, MultipartUpload tests #69
Conversation
krisis
commented
Jul 3, 2017
- Made cleanup to run even when test fail using finally block.
- Randomized bucket names to avoid collision across SDK tests.
@krisis I tried running the tests on localhost with Minio server container running, I get the below error in aws-sdk-php/error.log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the test issues as commented.
- CopyObject, DeleteObjects, GetBucketLocation - Made cleanup to run even when test fail using finally block. - Randomized bucket names to avoid collision across SDK tests.
@nitisht I have fixed the runtime error. |
There is one test case failure with PHP tests - related to Minio Server FS issue (minio/minio#4625) |