Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php: Add GetObject, PutObject, MultipartUpload tests #69

Merged
merged 4 commits into from
Jul 4, 2017

Conversation

krisis
Copy link
Member

@krisis krisis commented Jul 3, 2017

  • Made cleanup to run even when test fail using finally block.
  • Randomized bucket names to avoid collision across SDK tests.

@nitisht
Copy link
Contributor

nitisht commented Jul 3, 2017

@krisis I tried running the tests on localhost with Minio server container running, I get the below error in aws-sdk-php/error.log

PHP Notice:  Use of undefined constant http_ok - assumed 'http_ok' in /mint/run/core/aws-sdk-php/quick-tests.php on line 266
PHP Fatal error:  Uncaught exception 'Aws\S3\Exception\S3Exception' with message 'Error executing "DeleteBucket" on "http://127.0.0.1:9000/aws-sdk-php-bucket-14023"; AWS HTTP error: Client error: `DELETE http://127.0.0.1:9000/aws-sdk-php-bucket-14023` resulted in a `409 Conflict` response:
<?xml version="1.0" encoding="UTF-8"?>
<Error><Code>BucketNotEmpty</Code><Message>The bucket you tried to delete is not  (truncated...)
 BucketNotEmpty (client): The bucket you tried to delete is not empty - <?xml version="1.0" encoding="UTF-8"?>
<Error><Code>BucketNotEmpty</Code><Message>The bucket you tried to delete is not empty</Message><Key></Key><BucketName></BucketName><Resource>/aws-sdk-php-bucket-14023</Resource><RequestId>3L137</RequestId><HostId>3L137</HostId></Error>'

Exception: copyobject api failed for aws-sdk-php-bucket-14023 in /mint/run/core/aws-sdk-php/quick-tests.php:267
Stack trace:
#0 /mint/run/core/aws-sdk-php/quick-tests.php(339): testDeleteObjects(Object(Aws\S3\S3Client), 'aws-sdk-php-buc...', 'obj1')
#1 {main}

Next in /mint/run/core/aws-sdk-php/vendor/aws/aws-sdk-php/src/WrappedHttpHandler.php on line 192

Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the test issues as commented.

Krishnan Parthasarathi added 2 commits July 4, 2017 08:53
- CopyObject, DeleteObjects, GetBucketLocation
- Made cleanup to run even when test fail using finally block.
- Randomized bucket names to avoid collision across SDK tests.
@krisis
Copy link
Member Author

krisis commented Jul 4, 2017

@nitisht I have fixed the runtime error.

@nitisht
Copy link
Contributor

nitisht commented Jul 4, 2017

There is one test case failure with PHP tests - related to Minio Server FS issue (minio/minio#4625)

@nitisht nitisht merged commit 80c6cf0 into minio:master Jul 4, 2017
@nitisht nitisht mentioned this pull request Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants