Updating golangci-lint (#1277)

.github/workflows/kubernetes-tests.yml

@@ -112,7 +112,7 @@ jobs:
       - operator
     strategy:
       matrix:
-        go-version: [ 1.18.x ]
+        go-version: [ 1.18.x, 1.19.x ]
         os: [ ubuntu-latest ]
 
     steps:

.golangci.yml

@@ -37,4 +37,4 @@ issues:
         - deadcode
 
 service:
-  golangci-lint-version: 1.43.0 # use the fixed version to not introduce new linters unexpectedly
+  golangci-lint-version: 1.49.0 # use the fixed version to not introduce new linters unexpectedly

Makefile

@@ -27,7 +27,7 @@ all: build
 getdeps:
 	@echo "Checking dependencies"
 	@mkdir -p ${GOPATH}/bin
-	@echo "Installing golangci-lint" && go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.45.2
+	@echo "Installing golangci-lint" && go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.49.0
 
 verify: getdeps govet gotest lint
 

logsearchapi/server/server.go

@@ -141,7 +141,7 @@ func (ls *LogSearch) writeErrorResponse(w http.ResponseWriter, status int, msg s
 
 // ingestHandler handles:
 //
-//   POST /api/ingest?token=xxx
+//	POST /api/ingest?token=xxx
 //
 // The json body represents the Audit log data. If it is an empty object the
 // request is ignored but returns success.
@@ -167,7 +167,7 @@ func (ls *LogSearch) ingestHandler(w http.ResponseWriter, r *http.Request) {
 
 // queryHandler handles:
 //
-//   GET /api/query?token=xxx&q=(raw|reqinfo)&pageNo=0&pageSize=50&timeAsc|timeDesc&timeStart=?
+//	GET /api/query?token=xxx&q=(raw|reqinfo)&pageNo=0&pageSize=50&timeAsc|timeDesc&timeStart=?
 func (ls *LogSearch) queryHandler(w http.ResponseWriter, r *http.Request) {
 	// Request is assumed to be authenticated at this point.
 

pkg/apis/minio.min.io/v2/doc.go

@@ -19,7 +19,6 @@
 //
 // The `minio.min.io/v2` API was released with the v4.0.0 MinIO Operator. The MinIO Operator automatically converts existing tenants using the `/v1` API to `/v2`. +
 //
-//
 // +groupName=minio.min.io
 // +versionName=v2
 package v2

pkg/apis/minio.min.io/v2/types.go

@@ -30,7 +30,6 @@ import (
 // +kubebuilder:storageversion
 
 // Tenant is a https://kubernetes.io/docs/concepts/overview/working-with-objects/kubernetes-objects/[Kubernetes object] describing a MinIO Tenant. +
-//
 type Tenant struct {
 	metav1.TypeMeta   `json:",inline"`
 	metav1.ObjectMeta `json:"metadata,omitempty"`
@@ -74,7 +73,6 @@ type TenantDomains struct {
 
 // S3Features (`s3`) - Object describing which MinIO features to enable/disable in the MinIO Tenant. +
 // *Deprecated in Operator v4.3.2* +
-//
 type S3Features struct {
 	// *Optional* +
 	//
@@ -84,7 +82,6 @@ type S3Features struct {
 }
 
 // Features (`features`) - Object describing which MinIO features to enable/disable in the MinIO Tenant. +
-//
 type Features struct {
 	// *Optional* +
 	//
@@ -103,8 +100,6 @@ type Features struct {
 // The following parameters are specific to the `minio.min.io/v2` MinIO CRD API `spec` definition added as part of the MinIO Operator v4.0.0. +
 //
 // For more complete documentation on this object, see the https://docs.min.io/minio/k8s/reference/minio-operator-reference.html#minio-operator-yaml-reference[MinIO Kubernetes Documentation]. +
-//
-//
 type TenantSpec struct {
 	// *Required* +
 	//