Address review comments

- Capitalize SQL keywords - Create index concurrently during DB migration
minio · Jan 25, 2022 · 3839a99 · 3839a99
1 parent 89b4cb7
commit 3839a99
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/logsearchapi/server/db-migrations.go b/logsearchapi/server/db-migrations.go
@@ -111,8 +111,8 @@ func updateAccessKeyCol(ctx context.Context, c *DBClient) {
 
 func addAccessKeyColAndIndex(ctx context.Context, c *DBClient) error {
 	queries := []string{
-		`alter table request_info add access_key text`,
-		`create index request_info_access_key_index on request_info (access_key)`,
+		`ALTER table request_info ADD access_key text`,
+		`CREATE INDEX CONCURRENTLY request_info_access_key_index ON request_info (access_key)`,
 	}
 
 	return c.runQueries(ctx, queries, func(err error) bool {
@@ -129,21 +129,21 @@ func addAccessKeyColAndIndex(ctx context.Context, c *DBClient) error {
 
 func addAuditLogIndices(ctx context.Context, c *DBClient) error {
 	queries := []string{
-		`create index audit_log_events_log_index on audit_log_events USING btree ((log->>'requestID'))`,
-		`create index audit_log_events_event_time_index on audit_log_events (event_time desc)`,
+		`CREATE INDEX CONCURRENTLY audit_log_events_log_index ON audit_log_events USING btree ((log->>'requestID'))`,
+		`CREATE INDEX CONCURRENTLY audit_log_events_event_time_index ON audit_log_events (event_time desc)`,
 	}
 
 	return c.runQueries(ctx, queries, duplicateTblErr)
 }
 
 func addReqInfoIndices(ctx context.Context, c *DBClient) error {
 	queries := []string{
-		`create index request_info_api_name_index on request_info (api_name)`,
-		`create index request_info_bucket_index on request_info (bucket)`,
-		`create index request_info_object_index on request_info (object)`,
-		`create index request_info_request_id_index on request_info (request_id)`,
-		`create index request_info_response_status_index on request_info (response_status)`,
-		`create index request_info_time_index on request_info (time)`,
+		`CREATE INDEX CONCURRENTLY request_info_api_name_index ON request_info (api_name)`,
+		`CREATE INDEX CONCURRENTLY request_info_bucket_index ON request_info (bucket)`,
+		`CREATE INDEX CONCURRENTLY request_info_object_index ON request_info (object)`,
+		`CREATE INDEX CONCURRENTLY request_info_request_id_index ON request_info (request_id)`,
+		`CREATE INDEX CONCURRENTLY request_info_response_status_index ON request_info (response_status)`,
+		`CREATE INDEX CONCURRENTLY request_info_time_index ON request_info (time)`,
 	}
 
 	return c.runQueries(ctx, queries, duplicateTblErr)