fix: Effect must be 'NoExecute' when tolerationSeconds is set (#1740)

effect must be 'NoExecute' when tolerationSeconds is set Co-authored-by: guozhi.li <guozhi.li@daocloud.io>
minio · Aug 24, 2023 · c5b7586 · c5b7586
1 parent 619699e
commit c5b7586
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/api/tenant-handlers.go b/api/tenant-handlers.go
@@ -976,6 +976,12 @@ func parseTenantPoolRequest(poolParams *models.Pool) (*miniov2.Pool, error) {
 		if elem.TolerationSeconds != nil {
 			// elem.TolerationSeconds.Seconds is allowed to be nil
 			tolerationSeconds = elem.TolerationSeconds.Seconds
+
+			if tolerationSeconds != nil {
+				if corev1.TaintEffect(elem.Effect) != corev1.TaintEffectNoExecute {
+					return nil, fmt.Errorf(`Invalid value: "%s": effect must be 'NoExecute' when tolerationSeconds is set`, elem.Effect)
+				}
+			}
 		}
 
 		toleration := corev1.Toleration{