Defensive Validation to avoid NPE (#173)

minio · Jul 20, 2020 · e651e28 · e651e28
1 parent c3a5a98
commit e651e28
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/pkg/apis/operator.min.io/v1/helper.go b/pkg/apis/operator.min.io/v1/helper.go
@@ -414,6 +414,18 @@ func (mi *MinIOInstance) CreateMCSUser(minioSecret, mcsSecret map[string][]byte)
 
 // Validate returns an error if any configuration of the MinIO instance is invalid
 func (mi *MinIOInstance) Validate() error {
+	// Mandate a VolumeClaimTemplate
+	if mi.Spec.VolumeClaimTemplate == nil {
+		return errors.New("volume claim must be specified")
+	}
+	// Mandate a resource request
+	if mi.Spec.VolumeClaimTemplate.Spec.Resources.Requests == nil {
+		return errors.New("volume claim must specify resource request")
+	}
+	// Mandate a request of storage
+	if mi.Spec.VolumeClaimTemplate.Spec.Resources.Requests.Storage() == nil {
+		return errors.New("volume claim must specify resource storage request")
+	}
 	// Make sure the storage request is not 0
 	if mi.Spec.VolumeClaimTemplate.Spec.Resources.Requests.Storage().Value() <= 0 {
 		return errors.New("volume size must be greater than 0")