Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--console-image, --default-minio-image options doesn't work #1453

Closed
next0262 opened this issue Feb 17, 2023 · 12 comments · Fixed by minio/docs#1032
Closed

--console-image, --default-minio-image options doesn't work #1453

next0262 opened this issue Feb 17, 2023 · 12 comments · Fixed by minio/docs#1032
Assignees

Comments

@next0262
Copy link

next0262 commented Feb 17, 2023

I tried to initialize minio-operator with --console-image, --default-minio-image options like this :
$ kubectl minio init --console-image minio/console:v0.20.2 --console-image minio/console:v0.20.2 --default-minio-image minio/minio:RELEASE.2022-09-22T18-57-27Z --image minio/operator:v4.5.4

--console-image
Optional
The default MinIO Console image to use when creating a new MinIO tenant. Defaults to minio/console:v0.17.3.

--default-minio-image
Optional
The default minio image to use when creating a new MinIO tenant. Defaults to minio/minio:RELEASE.2022-05-26T05-48-41Z.

but, the operator didn't use these implicit images of the options for creating tenants., --console-image minio/console:v0.20.2 --default-minio-image minio/minio:RELEASE.2022-09-22T18-57-27Z,

What should i do? As i checked the code of the operator, it looks like not using these options. Am i right?

And i want to separate minio console from minio server for our minio operation environment. To do this, is there any guide i can refer to? or this separation is not recommended??

@next0262 next0262 changed the title --default-console-image, --default-minio-image doesn't work --default-console-image, --default-minio-image options doesn't work Feb 19, 2023
@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 21, 2023
@cesnietor cesnietor self-assigned this Oct 2, 2023
@stale stale bot removed the stale label Oct 2, 2023
@cesnietor cesnietor assigned cniackz and unassigned cesnietor Oct 2, 2023
@cesnietor
Copy link
Contributor

we'll test and see if we can reproduce this issue with latest code.

@cniackz
Copy link
Contributor

cniackz commented Oct 10, 2023

There is no --default-console-image flag in our plugin

@cniackz
Copy link
Contributor

cniackz commented Oct 10, 2023

Supported flags in version 5.0.9 are:

Cesars-MacBook-Pro:~ cniackz$ k minio version
v5.0.9
Cesars-MacBook-Pro:~ cniackz$ kubectl minio init --help

 'init' command creates MinIO Operator deployment along with all the dependencies.

Usage:
  minio init [flags]

Examples:
  kubectl minio init

Flags:
  -d, --cluster-domain string         cluster domain of the Kubernetes cluster (default "cluster.local")
      --console-image string          console image
      --console-tls                   enable tls for Operator console
      --default-kes-image string      default tenant KES image
      --default-minio-image string    default tenant MinIO image
  -h, --help                          help for init
  -i, --image string                  operator image (default "minio/operator:v5.0.9")
      --image-pull-secret string      image pull secret to be used for pulling MinIO Operator
  -n, --namespace string              namespace scope for this request (default "minio-operator")
      --namespace-to-watch string     namespace where operator looks for MinIO tenants, leave empty for all namespaces
  -o, --output                        dry run this command and generate requisite yaml
      --prometheus-name string        name of the prometheus managed by prometheus-operator
      --prometheus-namespace string   namespace of the prometheus managed by prometheus-operator
      --sts                           enable Operator sts (v1alpha1)

Global Flags:
      --kubeconfig string   Custom kubeconfig path

@cniackz
Copy link
Contributor

cniackz commented Oct 10, 2023

Proper name is --console-image updating the issue with correct name.

@cniackz cniackz changed the title --default-console-image, --default-minio-image options doesn't work --console-image, --default-minio-image options doesn't work Oct 10, 2023
@cniackz
Copy link
Contributor

cniackz commented Oct 10, 2023

There is an issue in our official docs: https://min.io/docs/minio/kubernetes/upstream/reference/kubectl-minio-plugin/kubectl-minio-init.html

Screenshot 2023-10-10 at 12 14 33 PM

--default-console-image does not exist in current version 5.0.9 of Operator, will create PR to fix this.

@cniackz
Copy link
Contributor

cniackz commented Oct 10, 2023

This --console-image refers to the console image in Operator.
We split UI in two, React project is now located in Operator for Operator and in Console for Console.
So in other words, --console-image is for the Operator's Console only.
If you intended to change the image in the Tenant, then, console image goes with MinIO image. So for that all you need to change is minio image not the operator console image. So here the explanation:

  • Tenant Console: --default-minio-image <---- Tenant Front End
  • MinIO Image: --default-minio-image <---- Tenant Back End
  • Operator console: --console-image <---- Operator Front End
  • Operator BackEnd image: --image <----- Operator Backend

Our official doc is wrong, I will update the docs and close this issue once we merge those changes in docs repo.

@cniackz
Copy link
Contributor

cniackz commented Oct 10, 2023

The other issue is located at https://min.io/docs/minio/kubernetes/upstream/reference/kubectl-minio-plugin/kubectl-minio-init.html#kubectl.minio.init.-console-image we are pointing to wrong repo for Console. We should point to operator here!.

ravindk89 pushed a commit to minio/docs that referenced this issue Oct 10, 2023
### Objective:

To correct our documentation because `--default-console-image` does not
exist in our Operator plugin.

### Related:

* This is related to minio/operator#1453 but
will partially fix the issue, there is more work to do. I will create
another PR for the missing update spot.
@cniackz
Copy link
Contributor

cniackz commented Oct 10, 2023

Ok, minio/docs#1031 has been merged, let's go into the next problem.

ravindk89 pushed a commit to minio/docs that referenced this issue Oct 10, 2023
### Objective:

To set the correct repository in our Official Documentation.

### Related:

To fix: minio/operator#1453

### Explanation:

TBD
@cniackz
Copy link
Contributor

cniackz commented Oct 10, 2023

@cniackz
Copy link
Contributor

cniackz commented Oct 10, 2023

@next0262 thank you for openning the issue; please read thru and test again in our latest Operator/Tenant versions. And if you encounter any other issue, let us know!. 👍

@nirmesh
Copy link

nirmesh commented Apr 26, 2024

Back-off pulling image "minio/console:v0.20.3" it is not coming up. i am using minio operator to install on microk8s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants