Operator UI allows creation of Tenant without required Encryption fields

[cesnietor]

If I write something on the Encryption fields, the Create button is disabled until all fields are set but if I started setting up some fields and I change between encryption methods, the Create button gets enabled and allows us to create a Tenant. Which then causes an error while trying to initialize it. I think we probably need to refresh the button state every time we change encryption methods.

Screen.Recording.2023-05-22.at.10.24.14.AM.mov

Since it allows the creation of the tenant, it fails while creating the KES pod

Expected Behavior

Created button should be disabled if Encryption is Enabled and not all fields are being set.
Created button state should be refreshed if changing encryption method and fields should also be refreshed to empty values.

Current Behavior

Encryption fields hold value even after changing encryption method

Possible Solution

Refresh button state on change of encryption method

Steps to Reproduce (for bugs)

1. On UI, Click on Create Tenant
2. Fillup initial required fields (name, namespace, etc)
3. Go to Encryption tab and enable it
4. Select Vault and write something on Endpoint
5. Change to AWS method
6. Go back to Vault Method (here the Create button is enabled but not all required fields have been set)

Context

Regression

Your Environment

• Version used (minio-operator): v5.0.4
• Environment name and version (e.g. kubernetes v1.17.2):
• Server type and version:
• Operating System and version (uname -a):
• Link to your deployment file:

[jiuker]

Something cannot work, see go-openapi/validate#152

[cesnietor]

@jiuker I believe this is also a UI issue, the UI portion of it doesn't seem to be addressed by the PR is that correct? cc @bexsoft

[jiuker]

@jiuker I believe this is also a UI issue, the UI portion of it doesn't seem to be addressed by the PR is that correct? cc @bexsoft

Yes. But the backend is where the data is finally validated. I am not good at frontend by the way. Right now it's not submittable, the backend will return an error but it won't show the error either, if you're good at front-end, you can help with that.

[cesnietor]

thanks, I'll reopen the issue then. Thanks @jiuker for adding a validation.

[jiuker]

thanks, I'll reopen the issue then. Thanks @jiuker for adding a validation.

Actually it was already there, it just didn't take effect, I went and submitted a pr to valid to fix the problem

[cesnietor]

closing this since operator ui has been deprecated, see https://github.com/minio/operator/blob/master/docs/notes/v6.0.0.md#whats-new for more